Skip to content

Remove usage telemetry (PostHog) from Hamilton#1512

Merged
skrawcz merged 2 commits intomainfrom
stefan/flip-telemetry
Mar 8, 2026
Merged

Remove usage telemetry (PostHog) from Hamilton#1512
skrawcz merged 2 commits intomainfrom
stefan/flip-telemetry

Conversation

@skrawcz
Copy link
Contributor

@skrawcz skrawcz commented Mar 8, 2026

Changes

ASF policy does not permit phone-home telemetry in released artifacts. This removes all PostHog event tracking while keeping hamilton/telemetry.py as a backwards-compatible no-op stub so downstream code that calls telemetry.disable_telemetry() continues to work without changes.

How I tested this

  • unit tests

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

ASF policy does not permit phone-home telemetry in released artifacts.
This removes all PostHog event tracking while keeping hamilton/telemetry.py
as a backwards-compatible no-op stub so downstream code that calls
`telemetry.disable_telemetry()` continues to work without changes.
Copy link
Collaborator

@Dev-iL Dev-iL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My main comment is - in addition to the noop stubs, mark these methods as deprecated (via decorator, or raising a warning), and remove all traces in an upcoming major release (e.g. 2.0 or 2.1 or 3.0)

Mark disable_telemetry() and is_telemetry_enabled() as deprecated
(warn at 1.89.0, fail at 2.0.0) so users get a clear signal to
remove these calls before the next major release.
@skrawcz skrawcz requested a review from Dev-iL March 8, 2026 16:05
@skrawcz skrawcz merged commit 45673b0 into main Mar 8, 2026
13 checks passed
@skrawcz skrawcz deleted the stefan/flip-telemetry branch March 8, 2026 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants