Skip to content

Fixes error message if no combine is passed to materializer#326

Merged
elijahbenizzy merged 1 commit intomainfrom
fix_materializer_error_string
Sep 7, 2023
Merged

Fixes error message if no combine is passed to materializer#326
elijahbenizzy merged 1 commit intomainfrom
fix_materializer_error_string

Conversation

@skrawcz
Copy link
Copy Markdown
Contributor

@skrawcz skrawcz commented Sep 7, 2023

I had a typo and the error was cryptic. This fixes that to explain that the combine= kwarg needs to be used.

Changes

  • materialization.py

How I tested this

  • locally

Notes

  • I don't like _build_result being the default node name post combine.

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

I had a typo and the error was cryptic. This fixes that to explain
that the `combine=` kwarg needs to be used.
@elijahbenizzy elijahbenizzy merged commit 7ca7d14 into main Sep 7, 2023
@elijahbenizzy elijahbenizzy deleted the fix_materializer_error_string branch September 7, 2023 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants