Skip to content

Fixes broken unit test for materializers#327

Merged
skrawcz merged 2 commits intomainfrom
fix_unit_materializer_unit_test
Sep 8, 2023
Merged

Fixes broken unit test for materializers#327
skrawcz merged 2 commits intomainfrom
fix_unit_materializer_unit_test

Conversation

@skrawcz
Copy link
Copy Markdown
Contributor

@skrawcz skrawcz commented Sep 8, 2023

The name it was getting before was ABCmeta... rather than the fully qualified class name. It seemed the simplest to just str() the object as it includes the fully qualified name in the class that way.

Changes

  • fixes broken unit test for materializer registration

How I tested this

  • locally

Notes

  • not sure how this worked in the first place...?

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

The name it was getting before was ABCmeta... rather than
the fully qualified class name. It seemed the simplest to just
str() the object as it includes the fully qualified name in the class
that way.
@skrawcz skrawcz changed the title Fixes broken unit tests for materializers Fixes broken unit test for materializers Sep 8, 2023
In 3.8 they introduced 5. So 4 is the highest
for 3.7.
@skrawcz skrawcz merged commit e124b2a into main Sep 8, 2023
@skrawcz skrawcz deleted the fix_unit_materializer_unit_test branch September 8, 2023 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant