Conversation
skrawcz
approved these changes
Apr 22, 2024
This was referenced May 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Visualizations now display the config value instead of type
Any. Also, nodes affected by configuration have the suffixnode_name: config_key.While working on this feature, I realized all high-level viz function except
display_all_functions()failed to show config nodes (#832). This is because it's the only function to pass the config via thenodesargument (typehamilton.node.Node) while other functions first filter a path of nodes, which excludes the config.Instead of a large refactoring,
hamilton.graph.create_graphviz_graph()now has a kwargconfigwhich raises an exception if left toNone. It's the caller's responsibility to have thisconfigmatch the actual config value that lead to the set ofnodespassed. This unlikely to cause problem unless people dig into internal APIs.Changes
configkwarg tocreate_graphviz_graph()and upstream callerscreate_graphviz_graph()display config nodesFunctionGraph.display()and high-levelDriver.display_andDriver.visualize_create_graphviz_graph()configkwargHow I tested this
Notes
Checklist