Skip to content

Guards SDK when pulling code that can't be hashed#856

Merged
skrawcz merged 2 commits intomainfrom
sdk_guard_no_source
Apr 26, 2024
Merged

Guards SDK when pulling code that can't be hashed#856
skrawcz merged 2 commits intomainfrom
sdk_guard_no_source

Conversation

@skrawcz
Copy link
Contributor

@skrawcz skrawcz commented Apr 26, 2024

Likely when someone has a dynamic python module
that doesn't have source code. This guards against that.

Changes

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

skrawcz added 2 commits April 25, 2024 22:35
Likely when someone has a dynamic python module
that doesn't have source code. This guards against that.
To push out guarding no source code issue.
@skrawcz skrawcz merged commit 6812861 into main Apr 26, 2024
@skrawcz skrawcz deleted the sdk_guard_no_source branch April 26, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant