jupyter V2.1 with backwards compatible changes#917
Merged
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
skrawcz
requested changes
May 24, 2024
Contributor
skrawcz
left a comment
There was a problem hiding this comment.
looks good, but undelete %incr_cell_to_module
skrawcz
reviewed
May 24, 2024
Co-authored-by: Stefan Krawczyk <stefan@dagworks.io>
skrawcz
approved these changes
May 27, 2024
Contributor
skrawcz
left a comment
There was a problem hiding this comment.
Looks good. I assume you've tested it, e.g. %incr_cell_to_module still works? :)
added 5 commits
May 28, 2024 13:34
…c/hamilton into plugins/jupyter-v2.1
Contributor
|
Cool - I'd squash merge this PR when it's ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reimplementation of #846 with backwards compatible changes with V1.
Compared to V2:
module_nameas positional or named arg (-m/--module_name)-c/--config-h/--help-r/--rebuild-drivers-v/--verbose-c/--config%%insert_moduleto%%module_to_cellCurrently ignores the
%%incr_cell_to_module. We have to consider what it means to deduplicate these 100+ lines of logic. If this feature truly adds value, it should be an argument instead of a separate magic. I propose-a/--append INDEX. This means the magic would now require to be stateful though opening opportunities for more bugs.How I tested this
The notebook
tutorial.ipynbcovers all implemented functionalities, so it's a good test for intended behavior.TODO
%%cell_to_module%%incr_cell_to_module