Skip to content

[HUDI-2770] - Docs for (HUDI-2737) - Use earliest instant for async compaction and clustering#4010

Merged
bhasudha merged 1 commit intoapache:asf-sitefrom
kywe665:compaction_asf-site
Nov 24, 2021
Merged

[HUDI-2770] - Docs for (HUDI-2737) - Use earliest instant for async compaction and clustering#4010
bhasudha merged 1 commit intoapache:asf-sitefrom
kywe665:compaction_asf-site

Conversation

@kywe665
Copy link
Copy Markdown

@kywe665 kywe665 commented Nov 16, 2021

What is the purpose of the pull request

In PR: #3991, the --instant-time is no longer required for Hudi compaction and clustering utilities. As I made the simple change for this I also discovered that the compaction docs were unclear on how to schedule and then separately execute compaction asynchronously.

Brief change log

  • Added note about --instant-time no longer being required in clustering.md
  • Added note about --instant-time no longer being required in compaction.md
  • Reworded and expanded compaction doc to make scheduling vs execution clear

Verify this pull request

This pull request is doc changes only.

Committer checklist

  • [ X] Has a corresponding JIRA in PR title & commit

  • [X ] Commit message is descriptive of the change

  • [ X] CI is green

  • [X ] Necessary doc changes done or have another open PR

  • [ X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@kywe665
Copy link
Copy Markdown
Author

kywe665 commented Nov 16, 2021

@yihua take a look to see if this covers your updates in PR: #3991

Copy link
Copy Markdown
Contributor

@yihua yihua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. Improved clarity. I only have a few minor comments.

Comment thread website/docs/clustering.md Outdated
Comment thread website/docs/compaction.md Outdated
Comment thread website/docs/compaction.md Outdated
Comment thread website/docs/cli.md Outdated
Comment thread website/docs/compaction.md Outdated
Comment thread website/docs/clustering.md Outdated
Copy link
Copy Markdown
Contributor

@yihua yihua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I'll let @bhasudha take another pass.

Comment thread website/docs/compaction.md Outdated
Comment thread website/docs/compaction.md Outdated
Comment thread website/docs/compaction.md Outdated
Comment thread website/versioned_docs/version-0.9.0/cli.md Outdated
Copy link
Copy Markdown
Contributor

@bhasudha bhasudha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kywe665 Left some comments. Please let me know if you need clarification on them.

@kywe665
Copy link
Copy Markdown
Author

kywe665 commented Nov 23, 2021

Thanks @bhasudha, I made the corresponding updates

Copy link
Copy Markdown
Contributor

@bhasudha bhasudha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @kywe665

Copy link
Copy Markdown
Contributor

@bhasudha bhasudha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kywe665 do you want to rephrase the commit message to avoid commit msg from all of the individual commit messages that includes feedback and reviews ? I think we can then merge this one.

…is no longer a required parameter; Added the new kafka-connect-sink reference into the streming ingestion page
@kywe665 kywe665 force-pushed the compaction_asf-site branch from 349c9c6 to acc0f62 Compare November 24, 2021 00:07
@bhasudha bhasudha merged commit c25db93 into apache:asf-site Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants