Extend HTTPClient Builder to allow setting a proxy server #10052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
amogh-jahagirdar
left a comment
amogh-jahagirdar
left a comment
There was a problem hiding this comment.
Thanks @harishch1998 ! I think this is close just a few nits and some additional validation I think we should add.
nastra
reviewed
Apr 8, 2024
nastra
reviewed
Apr 8, 2024
nastra
reviewed
Apr 8, 2024
nastra
reviewed
Apr 11, 2024
nastra
reviewed
Apr 11, 2024
nastra
reviewed
Apr 11, 2024
nastra
reviewed
Apr 11, 2024
nastra
reviewed
Apr 11, 2024
nastra
reviewed
Apr 11, 2024
nastra
reviewed
Apr 11, 2024
nastra
approved these changes
Apr 11, 2024
Contributor
nastra
left a comment
nastra
left a comment
There was a problem hiding this comment.
LGTM, I'll wait in case @amogh-jahagirdar has any other comments
Contributor
|
@harishch1998 can you please rebase the PR and fix the merge conflict(s)? |
amogh-jahagirdar
approved these changes
Apr 11, 2024
Contributor
|
Once it's rebased, I'll run the checks and after they pass, I'll merge! Thanks for contributing @harishch1998 , and thanks @nastra for the review |
* Extend httpclientbuilder to allow setting proxy * Add tests and address comments * Fix preconditions message * Add basic authentication for proxy
harishch1998
force-pushed
the
snow-extend-httpclientbuilder-to-allow-setting-proxy
branch
from
0753883 to
edfade3
Compare
sasankpagolu
pushed a commit
to sasankpagolu/iceberg
that referenced
this pull request
Oct 27, 2024
zachdisc
pushed a commit
to zachdisc/iceberg
that referenced
this pull request
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes code changes to extend the capability of the existing rest HTTPClient to allow setting a proxy server with basic username/password authentication. The requests made by the HTTPClient will be routed via the proxy server if the HTTPClient is configured with one. If the HTTPClient is not configured with a proxy we default to the current behavior.