Introduce two properties for reading the connection timeout and socke… #10053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

nastra merged 5 commits into apache:main from Snowflake-Labs:snow-make-httpclient-timeout-configurable

Apr 11, 2024

Contributor

harishch1998 commented Mar 28, 2024

This PR includes code changes to make the REST HTTPClient's socket and connection timeout values configurable. Introducing two new properties to help achieve this.


          Introduce two properties for reading the connection timeout and socke…

d878e58

…t timeout (#10)

* Introduce two properties for reading the connection timeout and socket timeout values

* Rulin and Maninder comments

* Refactor and add test

* Refactor to make constructor cleaner

* Minor fixes

* Test socket timeout behavior

github-actions bot added the core label

nastra reviewed

View reviewed changes

core/src/test/java/org/apache/iceberg/rest/TestHTTPClient.java Outdated Show resolved Hide resolved

core/src/main/java/org/apache/iceberg/rest/HTTPClient.java Outdated Show resolved Hide resolved

core/src/main/java/org/apache/iceberg/rest/HTTPClient.java Outdated Show resolved Hide resolved

core/src/main/java/org/apache/iceberg/rest/HTTPClient.java Show resolved Hide resolved

core/src/main/java/org/apache/iceberg/rest/HTTPClient.java Outdated Show resolved Hide resolved

core/src/test/java/org/apache/iceberg/rest/TestHTTPClient.java Outdated Show resolved Hide resolved

core/src/main/java/org/apache/iceberg/rest/HTTPClient.java Outdated Show resolved Hide resolved

core/src/main/java/org/apache/iceberg/rest/HTTPClient.java Outdated Show resolved Hide resolved


          Comments

2fb6c29

harishch1998 requested a review from nastra

April 1, 2024 16:38

nastra reviewed

View reviewed changes

core/src/main/java/org/apache/iceberg/rest/HTTPClient.java Outdated Show resolved Hide resolved

nastra reviewed

View reviewed changes

core/src/main/java/org/apache/iceberg/rest/HTTPClient.java Outdated Show resolved Hide resolved

nastra reviewed

View reviewed changes

core/src/main/java/org/apache/iceberg/rest/HTTPClient.java Outdated Show resolved Hide resolved

nastra reviewed

View reviewed changes

core/src/test/java/org/apache/iceberg/rest/TestHTTPClient.java Outdated Show resolved Hide resolved

nastra reviewed

View reviewed changes

core/src/test/java/org/apache/iceberg/rest/TestHTTPClient.java Outdated Show resolved Hide resolved

nastra reviewed

View reviewed changes

core/src/test/java/org/apache/iceberg/rest/TestHTTPClient.java Outdated Show resolved Hide resolved

nastra reviewed

View reviewed changes

core/src/test/java/org/apache/iceberg/rest/TestHTTPClient.java Outdated Show resolved Hide resolved

nastra reviewed

View reviewed changes

core/src/test/java/org/apache/iceberg/rest/TestHTTPClient.java Outdated Show resolved Hide resolved

nastra reviewed

View reviewed changes

core/src/test/java/org/apache/iceberg/rest/TestHTTPClient.java Outdated Show resolved Hide resolved


          Comments

b177059

harishch1998 requested a review from nastra

April 5, 2024 22:40

nastra reviewed

View reviewed changes

core/src/test/java/org/apache/iceberg/rest/TestHTTPClient.java Outdated Show resolved Hide resolved


          Comments

e4608f8

harishch1998 requested a review from nastra

April 8, 2024 08:44

nastra reviewed

View reviewed changes

core/src/test/java/org/apache/iceberg/rest/TestHTTPClient.java Outdated Show resolved Hide resolved

nastra reviewed

View reviewed changes

core/src/test/java/org/apache/iceberg/rest/TestHTTPClient.java Show resolved Hide resolved


          Comments

c24c5da

harishch1998 requested a review from nastra

April 10, 2024 23:23

nastra approved these changes

View reviewed changes

Contributor

nastra left a comment

LGTM, thanks @harishch1998

nastra merged commit 528b9b3 into apache:main

sasankpagolu pushed a commit to sasankpagolu/iceberg that referenced this pull request


          Core: Allow configuring socket/connection timeout in HTTPClient (apac…

d571ceb

…he#10053)

zachdisc pushed a commit to zachdisc/iceberg that referenced this pull request


          Core: Allow configuring socket/connection timeout in HTTPClient (apac…

e137fae

…he#10053)

fbertsch pushed a commit to fbertsch/iceberg that referenced this pull request


          Core: Allow configuring socket/connection timeout in HTTPClient (apac…

5ac717e

…he#10053)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core