Skip to content

Conversation

@lawofcycles
Copy link
Contributor

I propose following three modifications.

  • Fix a broken bullet point display.
Screenshot 2024-04-07 at 13 05 49 Screenshot 2024-04-07 at 13 05 56
  • Fix inconsistency between comment and SQL

-- CREATE audit-branch at snapshot 1234, retain audit-branch for 31 days, and retain the latest 31 days. The latest 3
snapshot snapshots, and 2 days worth of snapshots.
ALTER TABLE prod.db.sample CREATE BRANCH audit-branch
AS OF VERSION 1234 RETAIN 30 DAYS
WITH SNAPSHOT RETENTION 3 SNAPSHOTS 2 DAYS

  • A little clearer explanation of the respective options for DDLs.

I would be happy for you to review my proposal.

@github-actions github-actions bot added the docs label Apr 7, 2024
-- CREATE audit-branch at snapshot 1234, retain audit-branch for 31 days, and retain the latest 31 days. The latest 3 snapshot snapshots, and 2 days worth of snapshots.
ALTER TABLE prod.db.sample CREATE BRANCH `audit-branch`
AS OF VERSION 1234 RETAIN 30 DAYS
AS OF VERSION 1234 RETAIN 31 DAYS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rather than changing it here, can you please change it in the description above?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the description

@nastra nastra merged commit 9bb86fa into apache:main Apr 9, 2024
sasankpagolu pushed a commit to sasankpagolu/iceberg that referenced this pull request Oct 27, 2024
zachdisc pushed a commit to zachdisc/iceberg that referenced this pull request Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants