AWS: close underlying executor for DynamoDb LockManager #10132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regadas
changed the title
nastra
approved these changes
Apr 15, 2024
Contributor
nastra
left a comment
nastra
left a comment
There was a problem hiding this comment.
LGTM, thanks for fixing this
Contributor
Author
|
@nastra np thanks for taking a look! |
Contributor
|
I'll wait a bit with merging to give other reviewers a chance to also take a look at this |
singhpk234
approved these changes
Apr 15, 2024
Contributor
singhpk234
left a comment
singhpk234
left a comment
There was a problem hiding this comment.
LGTM as well, Thanks @regadas !
amogh-jahagirdar
approved these changes
Apr 15, 2024
Contributor
|
Good find @regadas ! Yeah seems like we would never cleanup the underlying heartbeat executor before this change. Thanks for fixing, and thanks for the reviews @nastra @singhpk234 |
sasankpagolu
pushed a commit
to sasankpagolu/iceberg
that referenced
this pull request
Oct 27, 2024
zachdisc
pushed a commit
to zachdisc/iceberg
that referenced
this pull request
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new close method added to BaseLockManager, I noticed that DynamoDbLockManager was not reusing inherited
closeand, hence, not closing the underlying executor.It's my first PR here, so let me know if I'm missing some guidelines. Thx.