Aliyun: Remove spring-boot dependency #11291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuzhang
reviewed
Oct 10, 2024
aliyun/src/test/java/org/apache/iceberg/aliyun/oss/mock/AliyunOSSMockLocalStore.java
Outdated
Show resolved
Hide resolved
findepi
approved these changes
Oct 12, 2024
Member
findepi
left a comment
findepi
left a comment
There was a problem hiding this comment.
Thanks!
Removing redundant dependencies is always a good idea!
findepi
changed the title
jbonofre
force-pushed
the
SPRING_BOOT_CLEANUP
branch
from
4cf467a to
e97dca1
Compare
Member
Author
|
I'm fixing spotless check failure. Sorry about that. |
jbonofre
force-pushed
the
SPRING_BOOT_CLEANUP
branch
from
e97dca1 to
c34434d
Compare
Member
Author
|
@findepi @manuzhang I fixed the spotless. Sorry for the inconvenience. |
manuzhang
reviewed
Oct 24, 2024
Member
Author
|
@rdblue @RussellSpitzer as discussed together, this is the PR to remove the spring-boot dependency and use JDK HTTP server directly for mocking. |
Member
|
@jbonofre there is a conflict, you may want to resolve |
jbonofre
force-pushed
the
SPRING_BOOT_CLEANUP
branch
from
c34434d to
591e911
Compare
Member
Author
|
@findepi conflict resolved. Thanks. |
jbonofre
force-pushed
the
SPRING_BOOT_CLEANUP
branch
from
591e911 to
c1da64f
Compare
findepi
approved these changes
Oct 27, 2024
Member
Contributor
|
@jbonofre @RussellSpitzer Took the liberty of fixing this through the GitHub UI. Let's get this in 🚀 |
Member
|
Tests Passed and Merged Thanks @jbonofre for the PR and @manuzhang , @findepi and @Fokko for the review. |
zachdisc
pushed a commit
to zachdisc/iceberg
that referenced
this pull request
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the spring-boot dependency from Iceberg and implement Aliyun OSS Mock using the JDK HTTP server.