open-api: Fix testFixtures dependencies #11422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajantha-bhat
commented
Oct 29, 2024
| testFixturesImplementation project(':iceberg-gcp') | ||
| testFixturesImplementation project(':iceberg-azure') | ||
| testFixturesImplementation(libs.hadoop3.common) { | ||
| exclude group: 'log4j' |
Member
Author
There was a problem hiding this comment.
exclusion copied from other modules.
Needed hadoop dependency for Configuration class in RCKUtils
ajantha-bhat
commented
Oct 29, 2024
| exclude group: 'org.codehaus.woodstox' | ||
| exclude group: 'org.eclipse.jetty' | ||
| } | ||
| testFixturesImplementation project(path: ':iceberg-bundled-guava', configuration: 'shadow') |
Member
Author
There was a problem hiding this comment.
Needed as we are using Maps from Guava.
ajantha-bhat
commented
Oct 29, 2024
| exclude group: 'org.eclipse.jetty' | ||
| } | ||
| testFixturesImplementation project(path: ':iceberg-bundled-guava', configuration: 'shadow') | ||
| testFixturesImplementation libs.junit.jupiter |
Member
Author
There was a problem hiding this comment.
Junit dependency was previously coming from core runtime path.
ajantha-bhat
commented
Oct 29, 2024
| testFixturesImplementation project(':iceberg-api') | ||
| testFixturesImplementation project(':iceberg-core') | ||
| testFixturesImplementation project(path: ':iceberg-core', configuration: 'testArtifacts') | ||
| testFixturesImplementation project(':iceberg-core').sourceSets.test.runtimeClasspath |
Member
Author
There was a problem hiding this comment.
This brings too many things from test runtime class path and creates a problem for shadow jar. For example it brings some csv files, GPL license file etc.
danielcweeks
approved these changes
Oct 29, 2024
Contributor
danielcweeks
left a comment
danielcweeks
left a comment
There was a problem hiding this comment.
Thanks @ajantha-bhat
Fokko
approved these changes
Oct 29, 2024
Contributor
|
@ajantha-bhat Great catch, thank you! |
zachdisc
pushed a commit
to zachdisc/iceberg
that referenced
this pull request
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Importing
testFixturesImplementation project(':iceberg-core').sourceSets.test.runtimeClasspathbrings everything to class path and creates problem for shadow jar.
Need to depend only on required classes.