Skip to content

Build: Bump Parquet to 1.15.0#11656

Merged
nastra merged 2 commits into
apache:mainfrom
Fokko:fd-bump-parquet
Dec 4, 2024
Merged

Build: Bump Parquet to 1.15.0#11656
nastra merged 2 commits into
apache:mainfrom
Fokko:fd-bump-parquet

Conversation

@Fokko
Copy link
Copy Markdown
Contributor

@Fokko Fokko commented Nov 26, 2024

@github-actions github-actions Bot added the build label Nov 26, 2024
@jbonofre
Copy link
Copy Markdown
Member

@Fokko it seems that jackson is shaded two times with Parquet 1.15. Do you want me to investigate ?

@jbonofre jbonofre self-requested a review November 26, 2024 15:11
@Fokko
Copy link
Copy Markdown
Contributor Author

Fokko commented Nov 26, 2024

@jbonofre It looks like the palantir baseline plugin doesn't know how to handle Java 22 multi-source packages. Let me take a look first.

@Fokko
Copy link
Copy Markdown
Contributor Author

Fokko commented Nov 26, 2024

Yes, looks like we need to drop JDK 11 first before we can upgrade to the newer baseline version that correctly knows how to handle the JDK22 shaded files: https://github.com/palantir/gradle-baseline/releases/tag/6.0.0

@github-actions github-actions Bot added the INFRA label Nov 26, 2024
@Fokko
Copy link
Copy Markdown
Contributor Author

Fokko commented Nov 26, 2024

@jbonofre is right, it was not correctly shaded: apache/parquet-java#3081

@Fokko Fokko requested a review from nastra December 4, 2024 08:48
@Fokko
Copy link
Copy Markdown
Contributor Author

Fokko commented Dec 4, 2024

It already landed in Spark: apache/spark#48970

Comment thread build.gradle Outdated
@nastra nastra changed the title Parquet: Bump to Apache Parquet 1.15.0 Build: Bump Parquet to 1.15.0 Dec 4, 2024
@nastra nastra merged commit c7cef9b into apache:main Dec 4, 2024
@Fokko Fokko deleted the fd-bump-parquet branch December 4, 2024 11:12
nastra pushed a commit to nastra/iceberg that referenced this pull request Dec 9, 2024
zachdisc pushed a commit to zachdisc/iceberg that referenced this pull request Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants