-
Notifications
You must be signed in to change notification settings - Fork 3k
docs: Add links checker #9965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add links checker #9965
Conversation
| --> | ||
|
|
||
|  | ||
|  |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Broken on the repository 😱
|
|
||
| [iceberg-docs]: https://iceberg.apache.org/docs/latest/ | ||
| [iceberg-spec]: https://iceberg.apache.org/spec | ||
| [roadmap]: https://iceberg.apache.org/roadmap/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed in #9941
| ``` | ||
|
|
||
| !!! info | ||
| <!-- markdown-link-check-disable-next-line --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything wiht {{ ... }} cannot be resolved 😭
| └─.asf.yaml | ||
| ``` | ||
|
|
||
| <!-- markdown-link-check-disable-next-line --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Server is not running in the check :)
|
|
||
| **Author**: [Dipankar Mazumdar](https://www.linkedin.com/in/dipankar-mazumdar/) | ||
|
|
||
| <!-- markdown-link-check-disable-next-line --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seem to be general issues with snowflake.com as it returns a 403 forbidden.
| 1. Update variable `latestVersions.iceberg` to the new release version in `landing-page/config.toml` | ||
| 2. Update variable `latestVersions.iceberg` to the new release version and | ||
| `versions.nessie` to the version of `org.projectnessie.nessie:*` from [versions.props](https://github.com/apache/iceberg/blob/master/versions.props) in `docs/config.toml` | ||
| `versions.nessie` to the version of `org.projectnessie.nessie:*` from [mkdocs.yml](https://github.com/apache/iceberg/blob/main/site/mkdocs.yml) in `docs/config.toml` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably we need to update these docs. cc @ajantha-bhat
| ### 0.7.0 | ||
|
|
||
| * Git tag: [apache-iceberg-0.7.0-incubating](https://github.com/apache/iceberg/releases/tag/apache-iceberg-0.7.0-incubating) | ||
| * [0.7.0-incubating source tar.gz](https://www.apache.org/dyn/closer.cgi/incubator/iceberg/apache-iceberg-0.7.0-incubating/apache-iceberg-0.7.0-incubating.tar.gz) -- [signature](https://dist.apache.org/repos/dist/release/incubator/iceberg/apache-iceberg-0.7.0-incubating/apache-iceberg-0.7.0-incubating.tar.gz.asc) -- [sha512](https://dist.apache.org/repos/dist/release/incubator/iceberg/apache-iceberg-0.7.0-incubating/apache-iceberg-0.7.0-incubating.tar.gz.sha512) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does not exist anymore.
nastra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, this is really great to have, thanks @Fokko
|
Thanks for the review @nastra and @manuzhang |
|
Will this fix get deployed to docs site immediately? |
|
Hi guys, Just reporting something I have noticed in the docs website of Iceberg for versions 1.5.0 and 1.5.1 and also the 'latest' section Lets say I go to - I guess its visible in Markdown that most such "internal hyperlink" ie., links that points to other sections of Iceberg documentation have ".md" in the URLs , such as - [ https://iceberg.apache.org/docs/1.5.0/spark-getting-started.md#spark-type-to-iceberg-type , all the above links with ".md" give 404 error - The requested URL was not found on this server. and so i removed the ".md" and they all go to right sections/webpages. [ https://iceberg.apache.org/docs/1.5.0/spark-getting-started#spark-type-to-iceberg-type , This is seen in all the docs pages for 1.5.0 , 1.5.1 and 'latest' , but not in "nightly" pages example - |
|
@bitsondatadev could you take a look at the issue that @print-sid8 reported please? |
|
@nastra and @print-sid8 These are known issues for previous versions. I'm a bit surprised it's not fixed in 1.5.1 which was just released. |
|
I back-ported the fix to 1.5.x releases in #10411 |
* docs: Add links checker * Comments * Fix broken paths * Fix moar links * Last few
No description provided.