Skip to content

Conversation

@Fokko
Copy link
Contributor

@Fokko Fokko commented Mar 15, 2024

No description provided.

@github-actions github-actions bot added INFRA docs Specification Issues that may introduce spec changes. labels Mar 15, 2024
-->

![Iceberg](https://iceberg.apache.org/docs/latest/img/Iceberg-logo.png)
![Iceberg](https://iceberg.apache.org/assets/images/Iceberg-logo.svg)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Broken on the repository 😱


[iceberg-docs]: https://iceberg.apache.org/docs/latest/
[iceberg-spec]: https://iceberg.apache.org/spec
[roadmap]: https://iceberg.apache.org/roadmap/
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed in #9941

```

!!! info
<!-- markdown-link-check-disable-next-line -->
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything wiht {{ ... }} cannot be resolved 😭

└─.asf.yaml
```

<!-- markdown-link-check-disable-next-line -->
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Server is not running in the check :)


**Author**: [Dipankar Mazumdar](https://www.linkedin.com/in/dipankar-mazumdar/)

<!-- markdown-link-check-disable-next-line -->
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seem to be general issues with snowflake.com as it returns a 403 forbidden.

1. Update variable `latestVersions.iceberg` to the new release version in `landing-page/config.toml`
2. Update variable `latestVersions.iceberg` to the new release version and
`versions.nessie` to the version of `org.projectnessie.nessie:*` from [versions.props](https://github.com/apache/iceberg/blob/master/versions.props) in `docs/config.toml`
`versions.nessie` to the version of `org.projectnessie.nessie:*` from [mkdocs.yml](https://github.com/apache/iceberg/blob/main/site/mkdocs.yml) in `docs/config.toml`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably we need to update these docs. cc @ajantha-bhat

### 0.7.0

* Git tag: [apache-iceberg-0.7.0-incubating](https://github.com/apache/iceberg/releases/tag/apache-iceberg-0.7.0-incubating)
* [0.7.0-incubating source tar.gz](https://www.apache.org/dyn/closer.cgi/incubator/iceberg/apache-iceberg-0.7.0-incubating/apache-iceberg-0.7.0-incubating.tar.gz) -- [signature](https://dist.apache.org/repos/dist/release/incubator/iceberg/apache-iceberg-0.7.0-incubating/apache-iceberg-0.7.0-incubating.tar.gz.asc) -- [sha512](https://dist.apache.org/repos/dist/release/incubator/iceberg/apache-iceberg-0.7.0-incubating/apache-iceberg-0.7.0-incubating.tar.gz.sha512)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not exist anymore.

Copy link
Contributor

@nastra nastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this is really great to have, thanks @Fokko

@Fokko Fokko merged commit 33838d5 into apache:main Mar 23, 2024
@Fokko
Copy link
Contributor Author

Fokko commented Mar 23, 2024

Thanks for the review @nastra and @manuzhang

@Fokko Fokko deleted the fd-check-links branch March 23, 2024 10:37
@manuzhang
Copy link
Member

Will this fix get deployed to docs site immediately?

@print-sid8
Copy link

Hi guys,

Just reporting something I have noticed in the docs website of Iceberg for versions 1.5.0 and 1.5.1 and also the 'latest' section

Lets say I go to -
https://iceberg.apache.org/docs/1.5.0/
and I click on the hyperlink that is in the following sentence , which points to another section of the documentation -

Iceberg will convert the column type in Spark to corresponding Iceberg type. Please check the section of [type compatibility on creating table](https://iceberg.apache.org/docs/1.5.0/spark-getting-started.md#spark-type-to-iceberg-type) for details.

I guess its visible in Markdown that most such "internal hyperlink" ie., links that points to other sections of Iceberg documentation have ".md" in the URLs , such as -

[ https://iceberg.apache.org/docs/1.5.0/spark-getting-started.md#spark-type-to-iceberg-type ,
https://iceberg.apache.org/docs/1.5.0/configuration.md ,
https://iceberg.apache.org/docs/1.5.0/partitioning.md ] and more.

all the above links with ".md" give 404 error - The requested URL was not found on this server.

and so i removed the ".md" and they all go to right sections/webpages.

[ https://iceberg.apache.org/docs/1.5.0/spark-getting-started#spark-type-to-iceberg-type ,
https://iceberg.apache.org/docs/1.5.0/configuration/ ,
https://iceberg.apache.org/docs/1.5.0/partitioning/ ]

This is seen in all the docs pages for 1.5.0 , 1.5.1 and 'latest' , but not in "nightly" pages

example -
[https://iceberg.apache.org/docs/1.5.1/configuration.md, https://iceberg.apache.org/docs/latest/configuration.md ]

@nastra
Copy link
Contributor

nastra commented May 7, 2024

@bitsondatadev could you take a look at the issue that @print-sid8 reported please?

@manuzhang
Copy link
Member

@nastra and @print-sid8 These are known issues for previous versions. I'm a bit surprised it's not fixed in 1.5.1 which was just released.

@manuzhang
Copy link
Member

I back-ported the fix to 1.5.x releases in #10411

zachdisc pushed a commit to zachdisc/iceberg that referenced this pull request Dec 23, 2024
* docs: Add links checker

* Comments

* Fix broken paths

* Fix moar links

* Last few
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs INFRA Specification Issues that may introduce spec changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants