Migrate Transactions, Partitions and Statistics files in Core to JUnit5#9999
Merged
nastra merged 4 commits intoapache:mainfrom Mar 20, 2024
Merged
Migrate Transactions, Partitions and Statistics files in Core to JUnit5#9999nastra merged 4 commits intoapache:mainfrom
nastra merged 4 commits intoapache:mainfrom
Conversation
tomtongue
changed the title
nastra
reviewed
Mar 19, 2024
| assertThat(spec.isUnpartitioned()).isTrue(); | ||
| assertThat(table.spec()).isEqualTo(spec); | ||
| assertThat(table.spec().lastAssignedFieldId()).isEqualTo(spec.lastAssignedFieldId()); | ||
| assertThat(table.specs()).containsEntry(spec.specId(), spec); |
Contributor
There was a problem hiding this comment.
this should do isEqualTo() as in the previous version of the code
Contributor
There was a problem hiding this comment.
or alternatively you can also use containsExactly(...)
nastra
reviewed
Mar 19, 2024
| assertThat(table.spec()).isEqualTo(spec); | ||
| assertThat(table.spec().lastAssignedFieldId()).isEqualTo(spec.lastAssignedFieldId()); | ||
| assertThat(table.specs()).containsEntry(spec.specId(), spec); | ||
| assertThat(table.specs().get(Integer.MAX_VALUE)).isNull(); |
nastra
reviewed
Mar 19, 2024
| assertThat(table.spec()).isEqualTo(spec); | ||
| assertThat(table.spec().lastAssignedFieldId()).isEqualTo(spec.lastAssignedFieldId()); | ||
| assertThat(table.specs()).containsEntry(spec.specId(), spec); | ||
| assertThat(table.specs().get(Integer.MAX_VALUE)).isNull(); |
Contributor
There was a problem hiding this comment.
please also update all other places
Contributor
Author
|
@nastra Thanks for the review. Could you check the new one when you have time? |
nastra
approved these changes
Mar 20, 2024
Contributor
Author
zachdisc
pushed a commit
to zachdisc/iceberg
that referenced
this pull request
Dec 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate the following test classes in iceberg-core to JUnit 5 and AssertJ style for #9085.
Current Progress
Transactions
TestCreateTransaction.javaTestReplaceTransaction.javaTestTransaction.javaPartitions:
TestPartitioning.javaTestPartitionSpecInfo.javaTestPartitionSpecParser.javaStatistics
TestSetPartitionStatistics.javaTestSetStatistics.javaOther
TestCommitReporting.java