KAFKA-19965: Increasing batch size to fix throttled delivery test #21081
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
apoorvmittal10
force-pushed
the
KAFKA-19965
branch
from
f1c1fbd to
5e767b0
Compare
DL1231
approved these changes
Dec 5, 2025
Collaborator
DL1231
left a comment
DL1231
left a comment
There was a problem hiding this comment.
Thanks for the patch, LGTM
AndrewJSchofield
approved these changes
Dec 5, 2025
apoorvmittal10
added a commit
that referenced
this pull request
Dec 5, 2025
…1081) The PR increases the max.poll.records config to 512 as the produced batch is of 512 records. SharePartition creates batches as per `share fetch` request batch-size config, which is currently controlled by max.poll.records. Drfault max.poll.records config is 500 and If producer generates multiple batches on log then there will be multiple batches in share partition. The throttled response in fetch is based on batch size in share partition hence subsequent throttles fetch calls can have different sizes as per the produces batches. To make sure the batch is of correct size in share partition increase the max.poll.records to 512. The same has been done in other test but missed in the current PR test: https://github.com/apache/kafka/blob/a8b1fb9203133a356732bf069aa3e0dd9b1716b7/clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/ShareConsumerTest.java#L3707 Reviewers: Andrew Schofield <[email protected]>, Lan Ding <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR increases the max.poll.records config to 512 as the produced
batch is of 512 records. SharePartition creates batches as per
share fetchrequest batch-size config, which is currently controlled bymax.poll.records. Drfault max.poll.records config is 500 and If producer
generates multiple batches on log then there will be multiple batches in
share partition. The throttled response in fetch is based on batch size
in share partition hence subsequent throttles fetch calls can have
different sizes as per the produces batches. To make sure the batch is
of correct size in share partition increase the max.poll.records to 512.
The same has been done in other test but missed in the current PR test:
kafka/clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/ShareConsumerTest.java
Line 3707 in a8b1fb9
Reviewers: Andrew Schofield [email protected], Lan Ding
[email protected]