Skip to content

Conversation

@dejan2609
Copy link
Contributor

@dejan2609 dejan2609 commented Dec 5, 2025

details:

  • Scala: 2.13.17 -->> 2.13.18 (note: Java compatible
    versions: from 8 to 26)
  • Scalafmt: 3.10.0 -->> 3.10.2
  • scalac scoverage plugin: 2.4.0 -->> 2.5.0

release notes:

https://github.com/scoverage/scalac-scoverage-plugin/releases/tag/v2.4.1
https://github.com/scoverage/scalac-scoverage-plugin/releases/tag/v2.4.2
https://github.com/scoverage/scalac-scoverage-plugin/releases/tag/v2.5.0

⚠️ Note: I just had to format scalac scoverage plugin links
above likecode due to a fact that github-actions bot is overzealous
(and it constantly forcing bad formatting by adding wrong oversized
heading).

@github-actions github-actions bot added triage PRs from the community build Gradle build or GitHub Actions small Small PRs labels Dec 5, 2025
@dejan2609
Copy link
Contributor Author

Build failed:

FAILURE: Build failed with an exception.


* What went wrong:
Execution failed for task ':streams:streams-scala:spotlessScalaCheck'.
> There were 36 lint error(s), they must be fixed or suppressed.
  src/main/scala/org/apache/kafka/streams/scala/FunctionsCompatConversions.scala:LINE_UNDEFINED scalafmt(java.lang.reflect.InvocationTargetException) java.lang.reflect.InvocationTargetException (...)
  src/main/scala/org/apache/kafka/streams/scala/ImplicitConversions.scala:LINE_UNDEFINED scalafmt(java.lang.reflect.InvocationTargetException) java.lang.reflect.InvocationTargetException (.

Thing is that Scalafmt version has to be changed not once but twice:

  • gradle/dependencies.gradle I changed it here ✅
  • checkstyle/.scalafmt.conf this one was forgoten ❌

I'll push another commit.

@dejan2609 dejan2609 force-pushed the scala-version-update branch from 4daa3c6 to bc21660 Compare December 5, 2025 11:15
@lianetm lianetm added ci-approved and removed triage PRs from the community labels Dec 5, 2025
Copy link
Collaborator

@mingyen066 mingyen066 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also need to update the scala version in the following files?

  • LICENSE-binary
  • bin/kafka-run-class.sh
  • bin/windows/kafka-run-class.bat

@dejan2609
Copy link
Contributor Author

dejan2609 commented Dec 5, 2025

Correct ! Another example that it's so easy to forget something (and even more: this is my own recent commit here ede6c90 that updates Scala version 🙂).

Thanx for the tip @mingyen066 !

@dejan2609 dejan2609 force-pushed the scala-version-update branch from bc21660 to b0dc527 Compare December 5, 2025 22:25
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Dec 5, 2025
@dejan2609
Copy link
Contributor Author

All tests are fine now ✅

@dejan2609 dejan2609 requested a review from mingyen066 December 6, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Gradle build or GitHub Actions ci-approved dependencies Pull requests that update a dependency file small Small PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants