Skip to content

Fix test failure in TestSoftDeletesDirectoryReaderWrapper on expected number of deletes#14057

Merged
easyice merged 1 commit intoapache:mainfrom
cwperks:fix-soft-deletes-test
Dec 18, 2024
Merged

Fix test failure in TestSoftDeletesDirectoryReaderWrapper on expected number of deletes#14057
easyice merged 1 commit intoapache:mainfrom
cwperks:fix-soft-deletes-test

Conversation

@cwperks
Copy link
Copy Markdown
Contributor

@cwperks cwperks commented Dec 11, 2024

Description

This PR fixes TestSoftDeletesDirectoryReaderWrapper.testAvoidWrappingReadersWithoutSoftDeletes which consistently fails with a reproducible seed:

./gradlew test --tests TestSoftDeletesDirectoryReaderWrapper.testAvoidWrappingReadersWithoutSoftDeletes -i \
-Dtests.seed=CB973876C2F6A82A \
-Dtests.locale=fr-SN \
-Dtests.timezone=Etc/GMT+7 \
-Dtests.asserts=true \
-Dtests.file.encoding=UTF-8

Thank you to @easyice for the suggested solution and pointers for this fix. For more details about the test failure see: #14020 (comment)

Resolves: #14020

… number of deletes

Signed-off-by: Craig Perkins <cwperx@amazon.com>
@easyice easyice merged commit c9b4bcd into apache:main Dec 18, 2024
benchaplin pushed a commit to benchaplin/lucene that referenced this pull request Dec 31, 2024
… number of deletes (apache#14057)

Signed-off-by: Craig Perkins <cwperx@amazon.com>
HUSTERGS pushed a commit that referenced this pull request Oct 12, 2025
… number of deletes (#14057)

Signed-off-by: Craig Perkins <cwperx@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TestSoftDeletesDirectoryReaderWrapper.testAvoidWrappingReadersWithoutSoftDeletes AssertionError: expected:<5> but was:<3>

2 participants