LUCENE-10319: make ForUtil#BLOCK_SIZE changeable#545
Closed
gf2121 wants to merge 9 commits intoapache:mainfrom
Closed
LUCENE-10319: make ForUtil#BLOCK_SIZE changeable#545gf2121 wants to merge 9 commits intoapache:mainfrom
gf2121 wants to merge 9 commits intoapache:mainfrom
Conversation
Contributor
|
I'm a bit torn as this also makes the code harder to read with all these constants with complex names. |
Contributor
Author
|
Thanks @jpountz ! This is indeed making codes harder to read. I tried to make all these complex constants generated from script, keeping |
gf2121
commented
Jan 5, 2022
| longs[longsIdx + 0] = l0; | ||
| } | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Let these codes be generated from the script, so that it can change with the change of BLOCK_SIZE.
… with out changing {{ and }}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In LUCENE-10315, I tried to generate a ForUtil whose BLOCK_SIZE=512, I thought it could be simple since it looks like i only need to change the BLOCK_SIZE, but it turns out that there are a lot of hard code values...
So this is trying to make all hard code value generated from the BLOCK_SIZE in case we need a ForUtil somewhere else or want to change BLOCK_SIZE in postings in feature.
I tried to make the BLOCK_SIZE = 64 / 256 and all tests passed.