Skip to content

[MRESOLVER-272] Update parent POM to 37, remove plugin version overrides, update bnd#193

Merged
cstamas merged 2 commits intomasterfrom
MRESOLVER-272-update-parent-pom
Sep 16, 2022
Merged

[MRESOLVER-272] Update parent POM to 37, remove plugin version overrides, update bnd#193
cstamas merged 2 commits intomasterfrom
MRESOLVER-272-update-parent-pom

Conversation

@cstamas
Copy link
Copy Markdown
Member

@cstamas cstamas commented Sep 14, 2022

Remove version overrides and update bnd plugin
as well.


https://issues.apache.org/jira/browse/MRESOLVER-272

Remove version overrides and update bnd plugin
as well.

---

https://issues.apache.org/jira/browse/MRESOLVER-272
@cstamas cstamas requested a review from michael-o September 14, 2022 18:23
@cstamas cstamas self-assigned this Sep 14, 2022
@cstamas
Copy link
Copy Markdown
Member Author

cstamas commented Sep 16, 2022

@michael-o take a look at this one as well ,please.... seems some ignores changed, similar to those you discuss on ML?

@michael-o
Copy link
Copy Markdown
Member

Yes, @kwin knows how to deal with.

@cstamas cstamas requested a review from kwin September 16, 2022 13:30
@kwin
Copy link
Copy Markdown
Member

kwin commented Sep 16, 2022

@cstamas I assume it is related to https://issues.apache.org/jira/browse/RAT-308. We can either add the Apache License header to it or add it to the ignores.

@cstamas
Copy link
Copy Markdown
Member Author

cstamas commented Sep 16, 2022

@kwin @michael-o "traded" old Travis rat ignore to gitattibutes, locally is OK, let me see CI.

@slawekjaranowski
Copy link
Copy Markdown
Member

I added .gitattributes to excluded list for RAT in apache/maven#792

@kwin
Copy link
Copy Markdown
Member

kwin commented Sep 16, 2022

Not sure about IP of a gitignore file but to me it seems safer to add an Apache License header to it according to https://www.apache.org/legal/src-headers.html#faq-exceptions given that .gitignore files are actually part of the Apache Release (compare with https://lists.apache.org/thread/pj1csswgmdo924gp2myvbx73516dpk7c).

@cstamas
Copy link
Copy Markdown
Member Author

cstamas commented Sep 16, 2022

IMHO, git config files carries no IP... they are more "environment" or so...

@cstamas cstamas changed the title [MRESOLVER-272] Update parent POM [MRESOLVER-272] Update parent POM to 37, remove plugin version overrides, update bnd Sep 16, 2022
@slawekjaranowski
Copy link
Copy Markdown
Member

I don't see creativity in .git* files - so IMHO header is not needed

@jira-importer
Copy link
Copy Markdown

Resolve #761

1 similar comment
@jira-importer
Copy link
Copy Markdown

Resolve #761

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants