Skip to content

Configure Wagon from settings.xml#1233

Merged
kwin merged 1 commit intomasterfrom
bugfix/configure-wagon
Mar 8, 2026
Merged

Configure Wagon from settings.xml#1233
kwin merged 1 commit intomasterfrom
bugfix/configure-wagon

Conversation

@kwin
Copy link
Member

@kwin kwin commented Feb 21, 2026

This regressed with
e414d23

This closes #1217

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MSITE-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MSITE-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

This regressed with
e414d23

This closes #1217
@kwin kwin force-pushed the bugfix/configure-wagon branch from e8bef61 to 2377628 Compare February 21, 2026 12:58
<artifactId>maven-resolver-transport-wagon</artifactId>
<version>1.4.1</version>
<!-- version shipping with Maven 3.6.3-->
<scope>compile</scope>
Copy link
Member Author

@kwin kwin Feb 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this provided from the Maven Core classloader?

Copy link
Member

@michael-o michael-o Feb 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cstamas Do you remember what we have changed back them for Maven 3.9.x and Resolver 1.9.x/2.0.x?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cstamas Do you remember what we have changed back them for Maven 3.9.x and Resolver 1.9.x/2.0.x?

Nope, but Wagon transport works even today in Maven 3 and even in 4... so unsure what site dropped and why.

@cstamas
Copy link
Member

cstamas commented Mar 3, 2026

LGTM

@kwin kwin marked this pull request as ready for review March 8, 2026 18:34
@kwin kwin merged commit 6c97398 into master Mar 8, 2026
45 checks passed
@kwin kwin deleted the bugfix/configure-wagon branch March 8, 2026 18:34
@github-actions github-actions bot added this to the 4.0.0 milestone Mar 8, 2026
@github-actions
Copy link

github-actions bot commented Mar 8, 2026

@kwin Please assign appropriate label to PR according to the type of change.

@kwin kwin added the bug Something isn't working label Mar 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sshExecutable from settings.xml ignored

3 participants