[maven-4.0.x] Fix GH-11199: Maven 4.0.0-rc-4 ignores defaultLogLevel #11227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue was that LookupInvoker always called setRootLoggerLevel() with INFO level even when no CLI options were specified, overriding configuration file settings by setting a system property. Changes: - LookupInvoker.prepareLogging(): Only call setRootLoggerLevel() when CLI options (-X, -q) are explicitly specified, allowing config file to work - MavenSimpleConfiguration: Improved switch statement clarity - Added comprehensive unit tests for both logging configuration and CLI behavior This ensures that maven.logger.defaultLogLevel=off in configuration files is properly respected when no CLI logging options are provided, while maintaining backward compatibility with CLI option overrides. Fixes apache#11199 (cherry picked from commit 49d7f01)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mastertomaven-4.0.x:Questions ?
Please refer to the Backport tool documentation