Skip to content

Conversation

@gnodet
Copy link
Contributor

@gnodet gnodet commented Sep 11, 2024

@gnodet gnodet force-pushed the remove-jline-ffm-direct-dep branch from 8a363ab to bcedfe0 Compare September 12, 2024 06:55
@gnodet gnodet added this to the 4.0.0-beta-5 milestone Sep 12, 2024
@gnodet gnodet changed the title Remove jline-terminal-ffm direct dependency [MNG-8261] Remove jline-terminal-ffm direct dependency Sep 17, 2024
@gnodet gnodet requested a review from cstamas September 17, 2024 20:50
Copy link
Member

@cstamas cstamas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could not we do this simpler? Maven really needs jansi-core, so everything else can be added in apache-maven "bundle" only, no?

@gnodet
Copy link
Contributor Author

gnodet commented Sep 18, 2024

Could not we do this simpler? Maven really needs jansi-core, so everything else can be added in apache-maven "bundle" only, no?

Well, that's what I did, i.e. make sure maven-embedded only depends on jansi-core. However the maven-jline subproject actually depends on JLine (it provides plexus interactivity services based on JLine).
Btw, those services were broken, so I restored them, this can be tested easily by using mvn versions:set and using left/right arrow keys (compare Maven 3.x with this PR).

@gnodet gnodet merged commit d77462e into apache:master Sep 28, 2024
@jira-importer
Copy link

Resolve #9994

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants