This repository was archived by the owner on Nov 17, 2023. It is now read-only.
add cpp example inception to nightly test#13534
Merged
nswamy merged 4 commits intoapache:masterfrom Dec 8, 2018
Merged
Conversation
Member
Author
|
@mxnet-label-bot add [pr-awaiting-testing] |
Member
Author
|
CI passed, but found out mlp test took a long time, changed max epochs to 10 to align with mlp_gpu, mlp_cpu examples. |
lupesko
suggested changes
Dec 5, 2018
Contributor
lupesko
left a comment
There was a problem hiding this comment.
Looks good, one issue you may have missed.
cpp-package/example/mlp.cpp
Outdated
|
|
||
| std::cout << "Training" << std::endl; | ||
| int max_iters = 20000; | ||
| int max_iters = 10; |
Contributor
There was a problem hiding this comment.
You are reducing max_iters to 10, but you did not change line 152 which has an if (iter % 100 == 0)
If you want to run for 10 epochs only I think you can remove the if condition on line 152.
I also suggest to rename iter to epochNum for readability.
Member
Author
There was a problem hiding this comment.
addressed comments and turns out it's iterating on a synthetic patterned data of size 128, it will take around 15000 epochs to get 90% acc. Renamed the variables and added comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
replace #13367
a follow up to add inception into nightly test after fix in #13284
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments