Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

add cpp example inception to nightly test#13534

Merged
nswamy merged 4 commits intoapache:masterfrom
roywei:add_cpp_test
Dec 8, 2018
Merged

add cpp example inception to nightly test#13534
nswamy merged 4 commits intoapache:masterfrom
roywei:add_cpp_test

Conversation

@roywei
Copy link
Member

@roywei roywei commented Dec 4, 2018

Description

replace #13367
a follow up to add inception into nightly test after fix in #13284

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • add cpp example test on inception

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@roywei roywei requested a review from nswamy as a code owner December 4, 2018 18:00
@roywei
Copy link
Member Author

roywei commented Dec 4, 2018

@mxnet-label-bot add [pr-awaiting-testing]

@marcoabreu marcoabreu added the pr-awaiting-testing PR is reviewed and waiting CI build and test label Dec 4, 2018
Copy link
Contributor

@stu1130 stu1130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@sandeep-krishnamurthy sandeep-krishnamurthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sandeep-krishnamurthy sandeep-krishnamurthy added pr-awaiting-merge Review and CI is complete. Ready to Merge and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 4, 2018
@roywei
Copy link
Member Author

roywei commented Dec 4, 2018

CI passed, but found out mlp test took a long time, changed max epochs to 10 to align with mlp_gpu, mlp_cpu examples.

Copy link
Contributor

@lupesko lupesko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one issue you may have missed.


std::cout << "Training" << std::endl;
int max_iters = 20000;
int max_iters = 10;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are reducing max_iters to 10, but you did not change line 152 which has an if (iter % 100 == 0)
If you want to run for 10 epochs only I think you can remove the if condition on line 152.
I also suggest to rename iter to epochNum for readability.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed comments and turns out it's iterating on a synthetic patterned data of size 128, it will take around 15000 epochs to get 90% acc. Renamed the variables and added comment

@nswamy nswamy merged commit f2ca66f into apache:master Dec 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

pr-awaiting-merge Review and CI is complete. Ready to Merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants