Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

ONNX ops: norm exported and lpnormalization imported#13806

Merged
Roshrini merged 6 commits intoapache:masterfrom
Roshrini:lpnorm-op
Jan 10, 2019
Merged

ONNX ops: norm exported and lpnormalization imported#13806
Roshrini merged 6 commits intoapache:masterfrom
Roshrini:lpnorm-op

Conversation

@Roshrini
Copy link
Member

@Roshrini Roshrini commented Jan 9, 2019

Description

Exported norm operator and imported lpnormalization.
Test cases added
@vandanavk

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@Roshrini Roshrini requested a review from szha as a code owner January 9, 2019 01:04
Copy link
Contributor

@vandanavk vandanavk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. just a few minor comments

@Roshrini
Copy link
Member Author

Roshrini commented Jan 9, 2019

@mxnet-label-bot Add [ONNX, pr-awaiting-review]

@marcoabreu marcoabreu added ONNX pr-awaiting-review PR is waiting for code review labels Jan 9, 2019
@Roshrini
Copy link
Member Author

Roshrini commented Jan 9, 2019

@zhreshold Can you please review this PR?

Copy link
Member

@zhreshold zhreshold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Roshrini Roshrini merged commit bc39183 into apache:master Jan 10, 2019
@Roshrini Roshrini deleted the lpnorm-op branch January 10, 2019 03:46
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
* ReduceL1, l2 export, lpnormalization import added

* fix

* fix

* fix

* fix
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

ONNX pr-awaiting-review PR is waiting for code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants