Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Removes unnecessary graphics-drivers ppa repository#13814

Merged
marcoabreu merged 1 commit intoapache:masterfrom
perdasilva:remove_nvidia_ppa
Jan 11, 2019
Merged

Removes unnecessary graphics-drivers ppa repository#13814
marcoabreu merged 1 commit intoapache:masterfrom
perdasilva:remove_nvidia_ppa

Conversation

@perdasilva
Copy link
Contributor

@perdasilva perdasilva commented Jan 9, 2019 •
edited
Loading

Description

Removes superfluous ppa repository add in ci script that installs nvidia dependencies

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

Comments

@perdasilva perdasilva changed the title [WIP] Removes unneeded nvidia driver ppa installation Removes unneeded nvidia driver ppa installation Jan 9, 2019
@perdasilva
Copy link
Contributor Author

perdasilva commented Jan 9, 2019

@mxnet-label-bot update [pr-awaiting-review]

@marcoabreu marcoabreu added the pr-awaiting-review PR is waiting for code review label Jan 9, 2019
lebeg
lebeg reviewed Jan 9, 2019
View reviewed changes
ci/docker/install/ubuntu_nvidia.sh
# Adding ppas frequently fails due to busy gpg servers, retry 5 times with 5 minute delays.
for i in 1 2 3 4 5; do add-apt-repository -y ppa:graphics-drivers && break || sleep 300; done

# Retrieve ppa:graphics-drivers and install nvidia-drivers.
Copy link
Contributor

@lebeg lebeg Jan 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need the ubuntu_nvidia.sh at all? CUDA is always part of the nvidia base image, no?

Copy link
Contributor Author

@perdasilva perdasilva Jan 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this installs the nvidia drivers and libcuda.so - which is needed by mxnet

Copy link
Contributor Author

@perdasilva perdasilva Jan 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lebeg - I did a little more digging: https://github.com/apache/incubator-mxnet/blob/master/ci/docker/Dockerfile.build.ubuntu_build_cuda#L47

Copy link
Contributor

@lebeg lebeg Jan 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see. Thanks!

@perdasilva perdasilva changed the title Removes unneeded nvidia driver ppa installation Removes unneeded graphics-drivers ppa repository Jan 9, 2019
@perdasilva perdasilva changed the title Removes unneeded graphics-drivers ppa repository Removes unnecessary graphics-drivers ppa repository Jan 9, 2019
@perdasilva
Copy link
Contributor Author

perdasilva commented Jan 10, 2019

@mxnet-label-bot update [pr-awaiting-merge]

@marcoabreu marcoabreu added pr-awaiting-merge Review and CI is complete. Ready to Merge and removed pr-awaiting-review PR is waiting for code review labels Jan 10, 2019
@marcoabreu marcoabreu merged commit 27846dd into apache:master Jan 11, 2019
@perdasilva perdasilva deleted the remove_nvidia_ppa branch February 8, 2019 07:37
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
@perdasilva
Removes unneeded nvidia driver ppa installation (apache#13814)
c1d5127
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@lebeg lebeg lebeg left review comments

@larroy larroy larroy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr-awaiting-merge Review and CI is complete. Ready to Merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@perdasilva @larroy @lebeg @marcoabreu