This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Fix jar path and add missing ones for spark jobs#14020
Merged
lanking520 merged 4 commits intoapache:masterfrom Feb 15, 2019
Merged
Fix jar path and add missing ones for spark jobs#14020lanking520 merged 4 commits intoapache:masterfrom
lanking520 merged 4 commits intoapache:masterfrom
Conversation
Fix path of jars / add missing jars in spark job remove print, reduce clutter
ChaiBapchya
suggested changes
Jan 30, 2019
Contributor
ChaiBapchya
left a comment
ChaiBapchya
left a comment
There was a problem hiding this comment.
LGTM
I can see an issue created.
Can merge once the CI tests pass.
Just want the clarification on 1 comment.
Thanks for the contribution. 👍
scala-package/spark/src/test/scala/org/apache/mxnet/spark/SharedSparkContext.scala
Show resolved
Hide resolved
Contributor
|
@mxnet-label-bot add [pr-awaiting-review, Scala] @aashudwivedi could you re-trigger the CI? |
Contributor
Author
|
I've re-triggered the CI, all tests have passed now. |
zachgk
reviewed
Feb 5, 2019
scala-package/spark/src/test/scala/org/apache/mxnet/spark/SharedSparkContext.scala
Outdated
Show resolved
Hide resolved
piyushghai
approved these changes
Feb 7, 2019
Contributor
piyushghai
left a comment
piyushghai
left a comment
There was a problem hiding this comment.
Looks okay to me!
Thanks for fixing this and welcome to the MXNet community :)
Contributor
Author
|
zachgk
suggested changes
Feb 7, 2019
scala-package/spark/src/test/scala/org/apache/mxnet/spark/SharedSparkContext.scala
Outdated
Show resolved
Hide resolved
zachgk
approved these changes
Feb 7, 2019
Contributor
|
@lanking520 ping for review/merge. |
lanking520
approved these changes
Feb 15, 2019
Member
lanking520
left a comment
lanking520
left a comment
There was a problem hiding this comment.
LGTM! Thanks for fixing the Spark example
stephenrawls
pushed a commit
to stephenrawls/incubator-mxnet
that referenced
this pull request
Feb 16, 2019
* Fix jar path and add missing ones for spark jobs Fix path of jars / add missing jars in spark job remove print, reduce clutter * fixes scalastyle violations * exclude all of javadoc, sources, bundle, and src while searching for jars * simplfied the exclude experession
drivanov
pushed a commit
to drivanov/incubator-mxnet
that referenced
this pull request
Mar 4, 2019
* Fix jar path and add missing ones for spark jobs Fix path of jars / add missing jars in spark job remove print, reduce clutter * fixes scalastyle violations * exclude all of javadoc, sources, bundle, and src while searching for jars * simplfied the exclude experession
vdantu
pushed a commit
to vdantu/incubator-mxnet
that referenced
this pull request
Mar 31, 2019
* Fix jar path and add missing ones for spark jobs Fix path of jars / add missing jars in spark job remove print, reduce clutter * fixes scalastyle violations * exclude all of javadoc, sources, bundle, and src while searching for jars * simplfied the exclude experession
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
* Fix jar path and add missing ones for spark jobs Fix path of jars / add missing jars in spark job remove print, reduce clutter * fixes scalastyle violations * exclude all of javadoc, sources, bundle, and src while searching for jars * simplfied the exclude experession
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix path of jars / add missing jars in spark job
remove print, reduce clutter
Description
Path of jar files in tests for MXNet on Spark are incorrect. This PR fixes it.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments