This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Conversation
hetong007
reviewed
Jan 30, 2019
hetong007
approved these changes
Jan 31, 2019
Contributor
hetong007
left a comment
There was a problem hiding this comment.
LGTM. Thank you for bringing it into R. Will merge it tomorrow if no further comment.
Note that for now NAG in MXNet is slower than SGD. So once we have something like mx.symbol.nag_update available, the implementation here needs to be updated.
stu1130
added a commit
to stu1130/incubator-mxnet
that referenced
this pull request
Feb 1, 2019
This reverts commit 439377d.
stephenrawls
pushed a commit
to stephenrawls/incubator-mxnet
that referenced
this pull request
Feb 16, 2019
vdantu
pushed a commit
to vdantu/incubator-mxnet
that referenced
this pull request
Mar 31, 2019
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Nesterov accelerated SGD for R API.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments