This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Conversation
- in order to match Julia `Base.clamp` interface - depwarn for `mx.clip` included
Member
eric-haibin-lin
left a comment
There was a problem hiding this comment.
Hi, what is the motivation for renaming the API?
Member
Author
|
There is a API named e.g. julia> A = [1,2,3,4,5]
5-element Array{Int64,1}:
1
2
3
4
5
julia> clamp.(A, 3, 4)
5-element Array{Int64,1}:
3
3
3
4
4So I renamed and make it overload the |
Contributor
|
@mxnet-label-bot add [pr-awaiting-review] |
Contributor
|
Why not leave both? |
Member
Author
|
I'm ok if making aliasing is an acceptable option. |
larroy
approved these changes
Mar 2, 2019
Contributor
larroy
left a comment
There was a problem hiding this comment.
LGTM, this is a matter of taste, so up to @iblis17
szha
approved these changes
Mar 6, 2019
Member
|
This PR has been merged. |
vdantu
pushed a commit
to vdantu/incubator-mxnet
that referenced
this pull request
Mar 31, 2019
- in order to match Julia `Base.clamp` interface - depwarn for `mx.clip` included
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
- in order to match Julia `Base.clamp` interface - depwarn for `mx.clip` included
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in order to match Base interface
depwarn for
mx.clipincludedChecklist