Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

R-Package Makefile#14068

Merged
hetong007 merged 2 commits intoapache:masterfrom
jeremiedb:jeremiedb-patch-1
Feb 15, 2019
Merged

R-Package Makefile#14068
hetong007 merged 2 commits intoapache:masterfrom
jeremiedb:jeremiedb-patch-1

Conversation

@jeremiedb
Copy link
Contributor

Adapt the rpkg Makefile for 3rdparties symlink.
Performs the copy of the actual files in the R-package installations directory rather than the symlink.

@vandanavk
Copy link
Contributor

@mxnet-label-bot add [R, pr-awaiting-review]

@anirudhacharya @ankkhedia for review

@marcoabreu marcoabreu added pr-awaiting-review PR is waiting for code review R labels Feb 6, 2019
@marcoabreu
Copy link
Contributor

Hey @jeremiedb , can you drop me an email please? My email is my github-handle@apache.org

@jeremiedb
Copy link
Contributor Author

@marcoabreu I wrote on your gmail.

@ankkhedia
Copy link
Contributor

@hetong007 @marcoabreu Could you please help review?

Copy link
Member

@szha szha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hetong007 feel free to decide when to merge.

@hetong007 hetong007 merged commit 3d0ffd2 into apache:master Feb 15, 2019
stephenrawls pushed a commit to stephenrawls/incubator-mxnet that referenced this pull request Feb 16, 2019
* rpkg Makefile

* rpkg makefile fix
drivanov pushed a commit to drivanov/incubator-mxnet that referenced this pull request Mar 4, 2019
* rpkg Makefile

* rpkg makefile fix
vdantu pushed a commit to vdantu/incubator-mxnet that referenced this pull request Mar 31, 2019
* rpkg Makefile

* rpkg makefile fix
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
* rpkg Makefile

* rpkg makefile fix
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

pr-awaiting-review PR is waiting for code review R

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants