This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Add GPU version of contrib.boolean_mask#14090
Merged
zheng-da merged 1 commit intoapache:masterfrom Feb 15, 2019
Merged
Conversation
Member
|
Please fix the CI issues :-) |
Contributor
|
great work! thanks |
zheng-da
reviewed
Feb 8, 2019
| prefix_sum, | ||
| prefix_sum, | ||
| idx_size, | ||
| Stream<gpu>::GetStream(s)); |
Contributor
There was a problem hiding this comment.
could you please add comments to explain the purpose of the code?
Contributor
Author
There was a problem hiding this comment.
Done, please check.
HyperZealot
force-pushed
the
boolean_mask_gpu
branch
from
ba9ec22 to
9f5e460
Compare
Contributor
|
@mxnet-label-bot add [pr-awaiting-review, Operator] |
HyperZealot
force-pushed
the
boolean_mask_gpu
branch
2 times, most recently
from
dcaee54 to
ba65b42
Compare
zheng-da
reviewed
Feb 12, 2019
src/operator/contrib/boolean_mask.cc
Outdated
| const std::vector<OpReqType> &req, | ||
| const std::vector<NDArray> &outputs) { | ||
| // TODO(@junrushao1994): This implementation is a proof-of-concept, | ||
| // hence very slow actually. Performance should be improved in the future. |
Contributor
There was a problem hiding this comment.
please remove the comment here.
zheng-da
approved these changes
Feb 12, 2019
Contributor
zheng-da
left a comment
zheng-da
left a comment
There was a problem hiding this comment.
please remove the old comments. otherwise, it looks good to me.
HyperZealot
force-pushed
the
boolean_mask_gpu
branch
from
ba65b42 to
421a037
Compare
Contributor
Author
|
@zheng-da Should be good for merge once build passes |
Member
|
Looks like there are some issues with the CI. Could you try again? |
HyperZealot
force-pushed
the
boolean_mask_gpu
branch
2 times, most recently
from
2ef0507 to
3051c7c
Compare
HyperZealot
force-pushed
the
boolean_mask_gpu
branch
from
3051c7c to
443d558
Compare
stephenrawls
pushed a commit
to stephenrawls/incubator-mxnet
that referenced
this pull request
Feb 16, 2019
drivanov
pushed a commit
to drivanov/incubator-mxnet
that referenced
this pull request
Mar 4, 2019
vdantu
pushed a commit
to vdantu/incubator-mxnet
that referenced
this pull request
Mar 31, 2019
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The same as title
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments