This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Speedup SequenceMask on GPU#14445
Merged
eric-haibin-lin merged 1 commit intoapache:masterfrom Mar 27, 2019
Merged
Conversation
99e82d3 to
9baa31d
Compare
Contributor
Author
|
@eric-haibin-lin @szha for review. |
f312304 to
efb4dc1
Compare
Contributor
|
@mxnet-label-bot add [CUDA, Operator, Performance, pr-awaiting-review] |
Contributor
Author
|
@eric-haibin-lin @szha ping for review. |
eric-haibin-lin
suggested changes
Mar 22, 2019
Member
eric-haibin-lin
left a comment
There was a problem hiding this comment.
Nice improvement! Two comments:
efb4dc1 to
0d5c11a
Compare
Contributor
Author
|
@eric-haibin-lin please check |
0d5c11a to
8339f09
Compare
eric-haibin-lin
approved these changes
Mar 27, 2019
vdantu
pushed a commit
to vdantu/incubator-mxnet
that referenced
this pull request
Mar 31, 2019
ZhennanQin
pushed a commit
to ZhennanQin/incubator-mxnet
that referenced
this pull request
Apr 3, 2019
nswamy
pushed a commit
that referenced
this pull request
Apr 5, 2019
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As title. Address #14124.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments
benchmark results on sample workload from #14124:
forward only: 48.589637756347656 ms -> 0.5544562339782715 ms 87.63x speedup
forward+backward: 97.38378977775574 ms -> 1.224109172821045 ms 79.55x speedup