This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Use USE_SIGNAL_HANDLER by default set to ON in CMakeLists.txt#14599
Merged
szha merged 2 commits intoapache:masterfrom Apr 30, 2019
Merged
Use USE_SIGNAL_HANDLER by default set to ON in CMakeLists.txt#14599szha merged 2 commits intoapache:masterfrom
szha merged 2 commits intoapache:masterfrom
Conversation
Contributor
|
@mxnet-label-bot Add [CMake, pr-awaiting-review] |
Member
|
@marcoabreu @anirudh2290 Can you please help review? |
access2rohit
pushed a commit
to access2rohit/incubator-mxnet
that referenced
this pull request
May 14, 2019
…#14599) * Use USE_SIGNAL_HANDLER by default set to ON in CMakeLists.txt * Fix lint error with NULL vs nullptr
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
…#14599) * Use USE_SIGNAL_HANDLER by default set to ON in CMakeLists.txt * Fix lint error with NULL vs nullptr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This will have the effect to provide stack traces on crashes by default in CMake based builds
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.