Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[v1.4.x] Set idx2name for Optimizer object (#14703)#14772

Merged
szha merged 1 commit intoapache:v1.4.xfrom
yuxihu:mod_opt_14x
Apr 23, 2019
Merged

[v1.4.x] Set idx2name for Optimizer object (#14703)#14772
szha merged 1 commit intoapache:v1.4.xfrom
yuxihu:mod_opt_14x

Conversation

@yuxihu
Copy link
Member

@yuxihu yuxihu commented Apr 22, 2019

Cherry-pick the change that fixes issue affecting model convergence when using Module API to v1.4.x branch.

* set idx2name for optimizer

* add unit test
@yuxihu yuxihu requested a review from szha as a code owner April 22, 2019 23:32
@yuxihu
Copy link
Member Author

yuxihu commented Apr 22, 2019

@junrushao1994 @szha Please help review and merge. Thanks.

Copy link
Member

@wkcn wkcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.Thank you!

@szha szha merged commit 0eab551 into apache:v1.4.x Apr 23, 2019
@yuxihu yuxihu deleted the mod_opt_14x branch April 23, 2019 13:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants