This repository was archived by the owner on Nov 17, 2023. It is now read-only.
[MKLDNN] Enable more convolution + activation fusion#14819
Merged
pengzhao-intel merged 12 commits intoapache:masterfrom May 17, 2019
Merged
[MKLDNN] Enable more convolution + activation fusion#14819pengzhao-intel merged 12 commits intoapache:masterfrom
pengzhao-intel merged 12 commits intoapache:masterfrom
Conversation
7 tasks
Contributor
pengzhao-intel
left a comment
There was a problem hiding this comment.
@TaoLv to review the change inside convolution.
Contributor
|
@ZhennanQin @xinyu-intel please help rebase the code and the TRT issue is fixed now :) |
Contributor
Author
|
@pengzhao-intel CI can pass now. |
Contributor
|
Great, I am taking a review again and will merge soon. |
pengzhao-intel
approved these changes
May 16, 2019
Contributor
pengzhao-intel
left a comment
There was a problem hiding this comment.
LGTM, will merge by the end of today if no further comment.
Contributor
|
Merging now, thanks for the contribution. |
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
* conv+act fusion * fix mobilenetv2 * fix lint * Add comment * Fix build * trigger ci * Fix CutGraphInputs * Run CI * run ci * trigger
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR enables below fusion pattern for MKLDNN backend:
FP32:
conv+sigmoid
conv+tanh
conv+softrelu
conv+clip(0, n) #(when n=6, it's mxnet version of relu6)
INT8:
conv+clip(0, n) #(when n=6, it's mxnet version of relu6)
Minor change:
resetAPI for selector to clean up internal state.@pengzhao-intel @TaoLv @reminisce @anirudh2290
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments