This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Re-enable static cached_op optimization#14931
Merged
pengzhao-intel merged 1 commit intoapache:masterfrom May 14, 2019
Merged
Conversation
Contributor
|
Was there a test added in the process of resolving the linked issue? |
Member
eric-haibin-lin
left a comment
There was a problem hiding this comment.
Would you mind elaborating what caused the issue and how you fixed it?
Contributor
@marcoabreu This is a performance issue in the gluonNLP so any suggestions for adding performance test on CI? |
ZhennanQin
commented
May 12, 2019
| } | ||
| state.op_states[i] = createop[node.source->op()]( | ||
| node.source->attrs, default_ctx, arg_shapes, arg_dtypes); | ||
| if (!config_.static_shape) { |
Contributor
Author
There was a problem hiding this comment.
@eric-haibin-lin This is the only changed line to fix this PR. We should re-create op state if static_shape is false.
Contributor
|
@mxnet-label-bot add [pr-awaiting-review] |
Contributor
|
@eric-haibin-lin @marcoabreu please help take a review :) |
Contributor
|
Will merge this PR at the end of today if there is no further comment. |
7 tasks
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR firstly filed at #14785, but reverted because of dmlc/gluon-nlp#690. Now it's fixed.
The fixed output is,
@pengzhao-intel @eric-haibin-lin
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments