Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[Bug Fix] Fixes call to build ubuntu gpu in nightly tests#14964

Merged
lanking520 merged 1 commit intoapache:masterfrom
perdasilva:fix_nightlytests
May 15, 2019
Merged

[Bug Fix] Fixes call to build ubuntu gpu in nightly tests#14964
lanking520 merged 1 commit intoapache:masterfrom
perdasilva:fix_nightlytests

Conversation

@perdasilva
Copy link
Contributor

@perdasilva perdasilva commented May 15, 2019

Description

PR #14513 update the CI GPU base images and changed the name of the function for compiling for gpu in ubuntu. The nightly tests Jenkins file is still calling the old function. This fixes that issue.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@lanking520 lanking520 merged commit 8b7e374 into apache:master May 15, 2019
@perdasilva perdasilva deleted the fix_nightlytests branch May 15, 2019 20:16
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants