This repository was archived by the owner on Nov 17, 2023. It is now read-only.
[Doc] Fix the broken link on the installation page#15036
Merged
aaronmarkham merged 1 commit intoapache:masterfrom May 22, 2019
Merged
[Doc] Fix the broken link on the installation page#15036aaronmarkham merged 1 commit intoapache:masterfrom
aaronmarkham merged 1 commit intoapache:masterfrom
Conversation
Member
Author
|
@pengzhao-intel @aaronmarkham Please review. |
aaronmarkham
suggested changes
May 22, 2019
Contributor
aaronmarkham
left a comment
There was a problem hiding this comment.
I'd really like to stay away from hard coding the urls. This makes previews hard to test - if you keep ending up on production instead of your preview.
You should be able to change this to ../faq/perf.md#intel-cpu.
aaronmarkham
approved these changes
May 22, 2019
Contributor
aaronmarkham
left a comment
There was a problem hiding this comment.
Actually nevermind. This page is so messed up. The link should have been converted from .md to .html, but that didn't happen. Better to fix the link for now. We still have a bug on this page though - .md links should get converted to html so that you can browse this on github and on the website.
access2rohit
pushed a commit
to access2rohit/incubator-mxnet
that referenced
this pull request
May 22, 2019
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the broken link for
MXNet tuning guideon the installation page: https://mxnet.incubator.apache.org/versions/master/install/index.html?platform=Linux&language=Python&processor=CPUPreviously we used a relative link address
../../faq/perf.md#intel-cpuwhich is compiled tohttps://mxnet.incubator.apache.org/versions/faq/perf.md#intel-cpumissingmasterin it.Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments