This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Showing proper error when csr array is not 2D in shape.#15242
Merged
eric-haibin-lin merged 3 commits intoapache:masterfrom Jun 20, 2019
Merged
Showing proper error when csr array is not 2D in shape.#15242eric-haibin-lin merged 3 commits intoapache:masterfrom
eric-haibin-lin merged 3 commits intoapache:masterfrom
Conversation
Contributor
Author
|
@eric-haibin-lin Please review. |
Contributor
|
@mxnet-label-bot add [Python, pr-awaiting-review] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #15239 We were allowing non 2D NDArrays to be created as a CSR that caused inconsistencies and also caused a crash when one tried to access .data on a CSR Matrix. The crash was coming from here : https://github.com/apache/incubator-mxnet/blob/master/src/operator/tensor/cast_storage-inl.h#L238.
The other places constructing CSRNDArray are already guarded by the shape checks.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.