This repository was archived by the owner on Nov 17, 2023. It is now read-only.
[MKLDNN] fix uint8 batch norm memory misuse#16034
Merged
pengzhao-intel merged 2 commits intoapache:masterfrom Aug 30, 2019
Merged
[MKLDNN] fix uint8 batch norm memory misuse#16034pengzhao-intel merged 2 commits intoapache:masterfrom
pengzhao-intel merged 2 commits intoapache:masterfrom
Conversation
Contributor
|
@ZhennanQin please help take a review. |
ZhennanQin
reviewed
Aug 30, 2019
Contributor
ZhennanQin
left a comment
There was a problem hiding this comment.
Please add a uint8 test for this.
Contributor
Author
uint8 bn test case has been added at: |
pengzhao-intel
approved these changes
Aug 30, 2019
Contributor
pengzhao-intel
left a comment
There was a problem hiding this comment.
Thanks for the fixing and merging now.
xziya
pushed a commit
to xziya/mxnet
that referenced
this pull request
Sep 2, 2019
* fix uint8 bn reorder memomry * update resnet152-v2 int8 acc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When using MKLDNN batch norm, uint8 input needs to be reordered (since MKLDNN bn only supports int8 input). This pr is to address the misuse of original data memory and reordered data memory.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Performance
@pengzhao-intel @ZhennanQin @ciyongch