This repository was archived by the owner on Nov 17, 2023. It is now read-only.
[Numpy] add numpy op bitwise_xor, hsplit, moveaxis, rot90#16257
Merged
reminisce merged 1 commit intoapache:masterfrom Oct 15, 2019
Merged
[Numpy] add numpy op bitwise_xor, hsplit, moveaxis, rot90#16257reminisce merged 1 commit intoapache:masterfrom
reminisce merged 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
@reminisce , @haojin2 , thx for reviewing |
sxjscience
reviewed
Sep 25, 2019
sxjscience
reviewed
Sep 26, 2019
sxjscience
suggested changes
Sep 26, 2019
Member
|
LGTM in general, for implementing the forward op based on the forward/backward of another op, you may refer to the PR in #12821 |
8ce4075 to
d36f54c
Compare
Contributor
Author
|
@sxjscience i refactor this code |
sxjscience
approved these changes
Oct 4, 2019
add numpy op bitwise_xor fix some format problems add numpy op moveaxis fix code style add numpy op rot90 fix pylint error updata rot90 address comments add numpy op hsplit refactor split compute function refactor moveaxis code
d36f54c to
9fd6c3d
Compare
aaronmarkham
pushed a commit
to aaronmarkham/incubator-mxnet
that referenced
this pull request
Oct 16, 2019
add numpy op bitwise_xor fix some format problems add numpy op moveaxis fix code style add numpy op rot90 fix pylint error updata rot90 address comments add numpy op hsplit refactor split compute function refactor moveaxis code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add numpy op bitwise_xor
fix some format problems
add numpy op moveaxis
fix code style
add numpy op rot90
fix pylint error
updata rot90
address comments
add numpy op hsplit
refactor split compute function
Description
(Brief description on what this PR is about)
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments