This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Move ops which don't support FP16 dtype to FP32 list#16668
Merged
anirudh2290 merged 1 commit intoapache:masterfrom Oct 29, 2019
Merged
Move ops which don't support FP16 dtype to FP32 list#16668anirudh2290 merged 1 commit intoapache:masterfrom
anirudh2290 merged 1 commit intoapache:masterfrom
Conversation
Member
Author
|
@ptrendx can you please take a look. |
a427a5e to
3aee75b
Compare
ptrendx
approved these changes
Oct 29, 2019
Member
ptrendx
left a comment
There was a problem hiding this comment.
LGTM. Why did you remove the BN v1 and Polling v1? Do they support fp16?
Member
Author
it was a mistake. removed it now. yes they do support FP16, they have their own InferType functions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some legacy ops call this InferType function here: https://github.com/apache/incubator-mxnet/blob/master/include/mxnet/operator.h#L228 ,which doesnt support FP16 dtype. Tweaking the AMP lists so that users don't run into issues like the one mentioned here: https://discuss.mxnet.io/t/convert-model-to-float16/5053/3
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments