This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Conversation
leezu
approved these changes
Jan 24, 2020
samskalicky
approved these changes
Jan 24, 2020
szha
previously requested changes
Jan 25, 2020
szha
reviewed
Jan 25, 2020
Member
szha
left a comment
szha
left a comment
There was a problem hiding this comment.
Looks like in other projects only the WIP disclaimer is kept.
See:
https://github.com/apache/incubator-hudi
https://github.com/apache/incubator-doris
Member
Author
|
Yes, i think the file should be kept separate according to here
re-trigger CI. |
Member
Author
|
rebased and Jenkins God please no time-out 🙏 🙏 🙏 |
Member
Author
|
replaced |
szha
reviewed
Jan 28, 2020
Member
szha
left a comment
szha
left a comment
There was a problem hiding this comment.
tools/pip/MANIFEST.in also needs to be updated.
Member
Author
done |
roywei
added a commit
to roywei/incubator-mxnet
that referenced
this pull request
Jan 28, 2020
* add disclaimer * add white list * fix exclude * remove disclaimer * update tools/pip
szha
pushed a commit
that referenced
this pull request
Jan 29, 2020
* Update NOTICE to fix copyright years (#17330) * Update LICENSE for fonts (#17365) * license np_einsum file under bsd (#17367) * license under bsd * fix rat exclude * remove unused file with license issue (#17371) * [LICENSE] fix cpp predcit license (#17377) * fix cpp predcit license * add white list (#210) * fix white list (#211) Co-authored-by: Lai Wei <royweilai@gmail.com> * add disclaimer (#17428) * add disclaimer * add white list * fix exclude * remove disclaimer * update tools/pip Co-authored-by: Haibin Lin <linhaibin.eric@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
address #17329 (comment)
so we can move forward with 1.6 release.
cc @ptrendx @szha @leezu @samskalicky