Fixes a NPE in CreateElementUtilities::computeLambdaReturn#8924
Merged
ebarboni merged 1 commit intoapache:deliveryfrom Oct 17, 2025
Merged
Fixes a NPE in CreateElementUtilities::computeLambdaReturn#8924ebarboni merged 1 commit intoapache:deliveryfrom
ebarboni merged 1 commit intoapache:deliveryfrom
Conversation
- hotfix for regression - updated loop to log Exceptions and continue computing the remaining ErrorRules in the queue Would be good to refactor the utility to return non-null values in future, usages treat empty list and null the same.
d1c565e to
7d6d9ac
Compare
lahodaj
approved these changes
Oct 17, 2025
Contributor
lahodaj
left a comment
There was a problem hiding this comment.
Looks good to me, thanks! (And sorry for the trouble.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exceptionsand continue computing the remainingErrorRulesin the queueWould be good to refactor the utility to return non-null values in future, usages seem to treat empty list and null the same.
reproducer taken from a different/unrelated issue (#4668):
Details