fix(integrations/unftp-sbe): avoid copy flush amplification#7217
Merged
Conversation
yihong0618
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A (related to discussion #7200).
Rationale for this change
unftp-sbecurrently usestokio::io::copyinput. Under slow uploads with small packets,copycan hit pending-read paths that flush the writer frequently, which interacts poorly with buffered multipart writers and can amplify memory usage.What changes are included in this PR?
tokio::io::copywith an explicit read/write loop inintegrations/unftp-sbe/src/lib.rs.read+write_all.Validation:
cargo check --lib(inintegrations/unftp-sbe)cargo clippy --lib -- -D warnings(inintegrations/unftp-sbe)cargo test --lib(inintegrations/unftp-sbe)Are there any user-facing changes?
No API changes. This adjusts internal upload transfer behavior to be more stable under slow/small-packet upload patterns.
AI Usage Statement
This PR was prepared with OpenAI Codex (GPT-5) for code editing and review support.