Skip to content

HDDS-12359. Bump async profiler to 2.9, awscli to 1.37#38

Merged
adoroszlai merged 1 commit intoapache:masterfrom
adoroszlai:bump-versions
Feb 18, 2025
Merged

HDDS-12359. Bump async profiler to 2.9, awscli to 1.37#38
adoroszlai merged 1 commit intoapache:masterfrom
adoroszlai:bump-versions

Conversation

@adoroszlai
Copy link
Contributor

@adoroszlai adoroszlai commented Feb 18, 2025

What changes were proposed in this pull request?

Bump dependencies:

  • async profiler 2.9
  • awscli 1.37 (latest version)

https://issues.apache.org/jira/browse/HDDS-12359

How was this patch tested?

#20 7.998 Successfully installed PyYAML-6.0.2 awscli-1.37.21 boto3-1.36.21 botocore-1.36.21 colorama-0.4.6 docutils-0.16 jmespath-1.0.1 pyasn1-0.6.1 python-dateutil-2.9.0.post0 robotframework-6.1.1 rsa-4.7.2 s3transfer-0.11.2 six-1.17.0 urllib3-1.26.20
...
#23 0.390 + mv async-profiler-2.9-linux-x64 /opt/profiler

https://github.com/adoroszlai/ozone-docker-runner/actions/runs/13377374876/job/37359340791#step:7:1137

@adoroszlai adoroszlai self-assigned this Feb 18, 2025
Copy link
Contributor

@jojochuang jojochuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change doesn't break robot tests due to HDDS-12123 because we run S3G in HTTP not HTTPS mode.

async profiler 2.9 is backward compatible. Moving to 3.0 and beyond requires change similar to this one https://github.com/apache/hbase/pull/6625/files

@adoroszlai adoroszlai merged commit 9953a27 into apache:master Feb 18, 2025
1 check passed
@adoroszlai adoroszlai deleted the bump-versions branch February 18, 2025 19:55
@adoroszlai
Copy link
Contributor Author

Thanks @jojochuang for the review. My main goal is to create an image that allows testing with the latest awscli.

@ivandika3
Copy link

Hi @adoroszlai , I didn't see the awscli upgrade in this patch. Is it implicitly upgraded somehow?

@adoroszlai
Copy link
Contributor Author

I didn't see the awscli upgrade in this patch. Is it implicitly upgraded somehow?

Yes, pip installs the latest one.

@ivandika3
Copy link

ivandika3 commented Mar 7, 2025

Yes, pip installs the latest one.

I see, this means that the AWS CLI version depends on when the pip install is run (I guess when the docker image is build).

IMO, I prefer if we can make it explicit so that we can know exactly which AWS CLI version is used. However, we can let this be for now.

@adoroszlai
Copy link
Contributor Author

IMO, I prefer if we can make it explicit so that we can know exactly which AWS CLI version is used.

I agree, we use the same method for Robot Framework and few other tools included in the image. Created HDDS-12499.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants