PARQUET-2425: Support non-grouped repeated fields in AvroSchemaConverter#1262
Merged
wgtmac merged 1 commit intoapache:masterfrom Feb 19, 2024
Merged
PARQUET-2425: Support non-grouped repeated fields in AvroSchemaConverter#1262wgtmac merged 1 commit intoapache:masterfrom
wgtmac merged 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
thanks! @Fokko , does this look ok to you? |
Member
|
cc @gszadovszky |
Fokko
approved these changes
Feb 18, 2024
Contributor
Fokko
left a comment
There was a problem hiding this comment.
I think it is reasonable to support lists and maps as well
gszadovszky
approved these changes
Feb 19, 2024
RustedBones
reviewed
Jul 16, 2024
| throw new UnsupportedOperationException( | ||
| "REPEATED not supported outside LIST or MAP. Type: " + parquetType); | ||
| if (parquetType.isRepetition(REPEATED)) { // If a repeated field is ungrouped, treat as REQUIRED per spec | ||
| fields.add(new Schema.Field(parquetType.getName(), Schema.createArray(fieldSchema))); |
Contributor
There was a problem hiding this comment.
This constructor is not available in avro 1.8. This leads to a runtime error
Cause: java.lang.NoSuchMethodError: 'void org.apache.avro.Schema$Field.<init>(java.lang.String, org.apache.avro.Schema)'
When using parquet-avro 1.14 with avro version 1.8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure you have checked all steps below.
Jira
them in the PR title. For example, "PARQUET-1234: My Parquet PR"
the ASF 3rd Party License Policy.
Tests
Commits
from "How to write a good git commit message":
Style
mvn spotless:apply -Pvector-pluginsDocumentation