+str Add startAfterNrOfConsumers to BroadcastHub.#275
Merged
He-Pin merged 1 commit intoapache:mainfrom Aug 5, 2023
Merged
Conversation
He-Pin
force-pushed
the
startAfterNrOfConsumers
branch
from
2988558 to
b97b38c
Compare
He-Pin
commented
Mar 27, 2023
| setKeepGoing(true) | ||
| callbackPromise.success(getAsyncCallback[HubEvent](onEvent)) | ||
| pull(in) | ||
| if (startAfterNrOfConsumers == 0) { |
Contributor
|
So I had a quick look into this and it appears to be the same as the equivalent upstream akka PR and it was merged there so there shouldn't be any problems. Only question arising from #261 is whether for Pekko 1.1 Ill have a proper look in the next couple days. |
Member
Author
|
@Aaronontheweb ping you too. @mdedetrich Yes， I was thinking the same, should we make the default value to |
Member
Author
|
Fail is #276 |
He-Pin
force-pushed
the
startAfterNrOfConsumers
branch
2 times, most recently
from
36cbd7c to
ea6741d
Compare
pjfanning
reviewed
Aug 4, 2023
He-Pin
commented
Aug 4, 2023
stream-tests/src/test/scala/org/apache/pekko/stream/scaladsl/HubSpec.scala
Show resolved
Hide resolved
He-Pin
force-pushed
the
startAfterNrOfConsumers
branch
from
ea6741d to
b9fb22e
Compare
pjfanning
approved these changes
Aug 4, 2023
Member
pjfanning
left a comment
pjfanning
left a comment
There was a problem hiding this comment.
lgtm - but I would appreciate if someone else has a look too
Member
Author
|
@mdedetrich would you like give another look, thanks |
Member
Author
|
I think this code is fine as it was merged into akka too. let me merge it to keep the pr queue shorter. |
This was referenced Jan 24, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: akka/akka-core#28327