[fix] producer do not create when topic update partition #295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BewareMyPower
requested changes
Jun 29, 2023
Contributor
BewareMyPower
left a comment
BewareMyPower
left a comment
There was a problem hiding this comment.
It's better to add a test. The current logic is protected by https://github.com/apache/pulsar-client-cpp/blob/main/tests/PartitionsUpdateTest.cc
Contributor
Author
I have improved PartitionsUpdateTest to verify the problem and fix. |
|
nice fix. |
Contributor
|
It might also fix #50, which was closed due to no reproduce code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When topic update partition, new producer is not created on the new partition. The root is runPartitionUpdateTask not work well.
Modifications
runPartitionUpdateTask should be executed next time when partition not updated.
Verifying this change
Documentation
doc-not-needed(Please explain why)